Ask the external provider for type info first in visitAnyNominalTypeRef #61081
Conversation
|
@swift-ci smoke test |
| } | ||
|
|
||
| auto FD = TC.getBuilder().getFieldTypeInfo(TR); | ||
| if (FD == nullptr || FD->isStruct()) { |
There was a problem hiding this comment.
I wonder if it were safer to just move it into the if (FD == nullptr || FD->isStruct()) condition?
There was a problem hiding this comment.
Would we want ExternalTypeInfo to be consulted when FD->isStruct() is true? In other words, should external lookup happen only when FD == nullptr
There was a problem hiding this comment.
I think there are two situations where we want to ask the external provider:
- We don't have any metadata for the type, ask the external provider.
- We have metadata for the type and it's a builtin (builtins are structs), ask the external provider as it may have more accurate information.
There was a problem hiding this comment.
in those two situations, should they be checked after TC.getBuilder().getFieldTypeInfo(TR)?
There was a problem hiding this comment.
currently this change checks before finding out whether either of those two cases apply.
There was a problem hiding this comment.
Yup! Just updated the patch :)
augusto2112
force-pushed
the
ask-external-provider-first
branch
2 times, most recently
from
b6accec to
7c18cdd
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS |
| } | ||
|
|
||
| const TypeInfo *visitAnyNominalTypeRef(const TypeRef *TR) { | ||
| auto AskExternalTypeInfoProvider = [&]() -> const TypeInfo * { |
There was a problem hiding this comment.
What do you think about queryExternalTypeInfoProvider ?
C/C++ imported types have Builtin type metadata. Ask the external provider when the type info we have is builtin.
augusto2112
force-pushed
the
ask-external-provider-first
branch
from
7c18cdd to
b30fc55
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Looks like TestSwiftFoundation crashed. |
|
@adrian-prantl it's actually |
|
@swift-ci smoke test macOS |
C++ imported types have Builtin type metadata. Ask the external provider before checking with builder.
This also has the added benefit
of not parsing all the typeref metadata in cases we don't have metadata for a type, but the external provider can resolve it.